Skip to content

Fix FomanticUI#2854

Open
samialfattani wants to merge 48 commits into
pallets-eco:masterfrom
samialfattani:fix/fomantic
Open

Fix FomanticUI#2854
samialfattani wants to merge 48 commits into
pallets-eco:masterfrom
samialfattani:fix/fomantic

Conversation

@samialfattani
Copy link
Copy Markdown
Contributor

@samialfattani samialfattani commented Apr 1, 2026 •
edited
Loading

This PR enhances Fomantic UI #2643 to be compatible with latest changes.

List of enhancements

Issues still need to be fixed

princerb and others added 30 commits July 25, 2025 18:01
@princerb
New theme added to theme.py: FomanticUI
39c3933
@princerb
Merge branch 'master' into f-theme-fomanticui
9c4b4e4
@princerb
Merge branch 'master' of https://github.com/princerb/flask-admin into…
3fa4e1f 
… f-theme-fomanticui
@princerb
Merge branch 'master' of https://github.com/princerb/flask-admin into…
63af33b 
… f-theme-fomanticui
@princerb
Theme FomanticUI templates: add index.html
c05a77a
@princerb
Theme FomanticUI templates: add master.html
cf2113b
@princerb
Theme FomanticUI templates: add static.html
82c22a8
@princerb
Theme FomanticUI templates: add layout.html
490f13c
@princerb
Theme FomanticUI templates: add actions.html
cc40388
@princerb
Theme FomanticUI: add actions.js
ea2ea43
@princerb
Theme FomanticUI templates: add model/layout.html
29c701f
@princerb
Theme FomanticUI templates: add model/list.html
7b7891c
@princerb
Theme FomanticUI templates: add inline_form.html
dad7c54
@princerb
Theme FomanticUI templates: add inline_list_base.html
331b7be
@princerb
Theme FomanticUI templates: add row_actions.html
0fa05bd
@princerb
Add type="button" to Inline Field adder button element & format doc
e6a23a1
@princerb
Theme FomanticUI: add RedisCLI templates
e83306e
@princerb
Theme FomanticUI: add initial base.html for testing
dd70021
@princerb
Refactor list template: remove inline styles, improve modal handling,…
8debbf6 
… and update button classes
@princerb
Update row actions: add modal support and fix icon classes
0f316c5
@princerb
Add FomanticUI admin library with form rendering and pagination macros
6ebf954
@princerb
Add breadcrumb utility for admin navigation
03f360e
@princerb
Add footer template with menu-based navigation links
08eab7f
@princerb
Add modal templates for create, edit, and details views
ca9b4fe
@princerb
Add modal functionality for form handling
1eaa8e8
@princerb
Add model CRUD templates for create, edit, and details views
7a01d61
@princerb
Add file management templates with modal support
0c12609
@princerb
Add helper functions for confirm dialogs and UI components
accfd07
@princerb
Add sidebar toggle functionality with localStorage persistence
a83c6cb
@princerb
Add advanced filtering functionality for admin lists
65e8855
princerb and others added 18 commits July 30, 2025 18:55
@princerb
Add form handling and validation JavaScript
113c3f7
@princerb
Add details view filtering functionality
51949db
@princerb
FomanticUI: Add Redis CLI interface JavaScript
cb1a3cc
@princerb
Theme FomanticUI: main CSS styles for admin interface - FomanticUI
7f0ab13
@princerb
Show loading state during modal form request
e2ab9b4
@princerb
Show loading state from beginning & apply _gettext for button texts
a51a6ac
@princerb
Replace is_modal param with modal_action_type for getting action name…
f3804bc 
… on client side
@princerb
Remove bs4-editable script/style includings from lib.html
7dc581b
@princerb
Add an optimal and universal max-width to admin forms
4fd36ec
@princerb
Remove unnecessary cases and comments from form.js
d91c8a0
@princerb
Merge branch 'master' into f-theme-fomanticui
411f643
@princerb
Merge branch 'master' into f-theme-fomanticui
56a839d
@princerb
Add an example fomanticui-test
6e4e93f
@princerb
Add an example fomanticui [Refactor mypy test]
de7c988
@princerb
Merge branch 'master' into f-theme-fomanticui
f5b9ce3
@samialfattani
add static local files
e177bb0 
- import JQuery as a local file
- import semantic.min.css (with its related fonts) and semantic.min.js as local files.
- fix Menu icon pallets-eco#2666
@samialfattani
fix css class generated by column name pallets-eco#2730
bb3793b
@samialfattani
fix pallets-eco#2829
6f00def 
- fix the CSRF token on delete files and directories pallets-eco#2829
@samialfattani samialfattani mentioned this pull request Apr 1, 2026
Open
13 tasks
@samialfattani samialfattani marked this pull request as ready for review April 1, 2026 20:23
@ElLorans
Copy link
Copy Markdown
Contributor

ElLorans commented Apr 7, 2026

Thanks!

  1. Why do we need docker to test this?
  2. Can we remove the fix the CSRF token on delete files and directories #2829 since it's a different topic?

@samialfattani
Copy link
Copy Markdown
Contributor Author

samialfattani commented Apr 29, 2026

  • Why do we need docker to test this?

i reviewed the source code but i couldn't find any docker refernce in the change. plus, i can run the examples/fomanticui normally like all other examples without need to docker.

Can we remove the #2829 since it's a different topic?

it was a bug in bootstrap4, i think if we are adding new UI we should avoid old mistakes. anyway the CSRF part within HTML pages and we still did not touch any *.py files.

@ElLorans ElLorans added the theme label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

theme

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samialfattani @ElLorans @princerb